Fix issue 784 slidesToShow #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #793 +/- ##
============================================
+ Coverage 40.04% 40.09% +0.04%
- Complexity 2324 2331 +7
============================================
Files 78 78
Lines 8236 8246 +10
============================================
+ Hits 3298 3306 +8
- Misses 4938 4940 +2
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
|
@gesinn-it-gea is this ready to merge? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the issue was caused by 2 concurrent problems, the parameter
slick-responsivewith wrong default value prevented all subsequent parameters to work, includingslick-slidesToShow, now all the parameters listed here https://www.semantic-mediawiki.org/wiki/Help:Carousel_format should work correctly.It has also been implemented the suggestion of @michaelfreiberg mentioned in the same issue