JavaScript: Distinguish {lo} and {lo,} in the regular expression parser.
#2854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esbena
reviewed
Feb 17, 2020
| @@ -0,0 +1,3 @@ | |||
| /a{1}/; | |||
| /a{1,}/; | |||
| /a{1,5}/; | |||
There was a problem hiding this comment.
Can we add the non-bound /a{,1}/; for completeness?
(/a{,1}/.test('a{,1}') === true)
There was a problem hiding this comment.
That's a syntax error, I believe.
There was a problem hiding this comment.
But I may be wrong, let me check...
There was a problem hiding this comment.
And indeed I'm wrong, we are more lenient than the ECMAScript standard. Yay, us!
There was a problem hiding this comment.
Apparently we treat a missing lower bound as zero, which is not how v8 handles it. That is, however, orthogonal to this PR.
max-schaefer
force-pushed
the
js/regexp-bounded-quantifier-fix
branch
from
c127ee1
to
cd1b5ca
Compare
esbena
previously approved these changes
Feb 17, 2020
max-schaefer
force-pushed
the
js/regexp-bounded-quantifier-fix
branch
from
cd1b5ca
to
bad4f36
Compare
esbena
previously approved these changes
Feb 18, 2020
max-schaefer
force-pushed
the
js/regexp-bounded-quantifier-fix
branch
from
bad4f36
to
00dc26b
Compare
max-schaefer
force-pushed
the
js/regexp-bounded-quantifier-fix
branch
from
00dc26b
to
4346691
Compare
esbena
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.