Issues/ 92 Add PR Reminder Panel #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manekenpix
added
type: enhancement
poftadeh
reviewed
Oct 16, 2019
| @@ -7,5 +7,6 @@ export default { | |||
| presentations: `http://${dashHost}:8083`, | |||
| meetings: `http://${dashHost}:8084`, | |||
| infrastructure: `http://${dashHost}:8085`, | |||
| github: `http://${dashHost}:8086` | |||
| github: `http://${dashHost}:8086`, | |||
| reminder: `http://${dashHost}:8086/pull-requests` | |||
There was a problem hiding this comment.
The dashboard no longer uses this config file (we should probably remove it). It will instead automagically fetch from the proper container in the Docker network based on the panel's name (i.e. http://data/{container-name}). I believe the getData function in Service.js will need to be changed to support fetching from a specific path (e.g. /pull-requests), since we would previously only fetch from the root endpoint of each container.
There was a problem hiding this comment.
Let's make removing Dashboard/src/config.js part of a separate issue.
naiuhz
previously approved these changes
Oct 18, 2019
manekenpix
force-pushed
the
pr-reminder-panel
branch
from
69ba7b4
to
6e389e5
Compare
poftadeh
approved these changes
Oct 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #92
The PR Reminder panel shows the following info (3 lines per PR):
number,PR title,repo,date,reviewers<--(icons, not text)labelsdescription(truncated, shows complete description when hovering over)Also,
dummy-data.jsnow has PR Reminder data for testing.The reminders don't include a
urlto the PR, issue or branch because the back-end doesn't provide that information. We should probably open an issue for that.