Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update eslint env for all environments we are using #119

Closed
humphd opened this issue Nov 9, 2019 · 0 comments
Closed

Update eslint env for all environments we are using #119

humphd opened this issue Nov 9, 2019 · 0 comments
Assignees
@RyanMarzec
Labels
area: CI/CD Continuous integration / Continuous delivery type: test Creation and development of test
Projects
Main

Comments

@humphd
Copy link
Contributor

humphd commented Nov 9, 2019

In .eslintrc.js, we currently define our environments like so:

"env": {
    "jest": true,
    "browser": true,
},

This is good, but we should add a few more from the list of possible env, specifically:

  • node - for node.js
  • es2017 - for ECMAScript 2017, which has async/await
@humphd humphd added area: CI/CD Continuous integration / Continuous delivery type: test Creation and development of test labels Nov 9, 2019
@Reza-Rajabi Reza-Rajabi added this to Issue in Main via automation Nov 9, 2019
@Reza-Rajabi Reza-Rajabi moved this from Issue to To do in Main Nov 9, 2019
@RyanMarzec RyanMarzec self-assigned this Nov 9, 2019
Reza-Rajabi added a commit that referenced this issue Nov 13, 2019
@Reza-Rajabi
Merge pull request #157 from RyanMarzec/issue-119
a6e8da0 
Fix #119 - update eslint with environments currently used
Main automation moved this from To do to Closed Nov 13, 2019
Sbaah added a commit to Sbaah/telescope that referenced this issue Nov 14, 2019
@Sbaah
Update local Fork (#1)
401b608 
* Created CODE-OF-CONDUCT.md

Initial code of conduct that's adapted from https://www.contributor-covenant.org

* resolve Seneca-CDOT#119 - update eslint with environments currently used

* created frontend folder and moved specified files to the folder

* Added the Redis URL to env.example and pass the URL when making Bull queue

* Made the requested changes for PR Seneca-CDOT#171

* moved feeds.txt to root directory

* Fix Seneca-CDOT#120: Added a test coverage report

* add server

add web server

add ndoemon and minimist

add package-lock.json

add removed file

separate routes from server

add server test

separate app, routes and server for easier testing

add supertest

move app from server.js into its own file

remove opn and minimist

change 'debug' script to something more meaningful, remove jest config object

add / endpoint test

remove 'index' from router require path

move files to backend directory, update paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RyanMarzec RyanMarzec

Labels
area: CI/CD Continuous integration / Continuous delivery type: test Creation and development of test
Projects
No open projects
Main
Closed
Milestone
No milestone
Development

No branches or pull requests
3 participants
@humphd @Reza-Rajabi @RyanMarzec