Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch testing error and display a more user friendly error message. #122

Closed
Immutablevoid opened this issue Nov 9, 2019 · 3 comments · Fixed by #553
Closed

Catch testing error and display a more user friendly error message. #122

Immutablevoid opened this issue Nov 9, 2019 · 3 comments · Fixed by #553
Assignees
Labels
type: test Creation and development of test

Comments

@Immutablevoid
Copy link
Contributor

Immutablevoid commented Nov 9, 2019

Currently when running npm test you get this error if the Redis server is off:

(node:46320) UnhandledPromiseRejectionWarning: Error: connect ECONNREFUSED 127.0.0.1:6379
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1106:14)
(node:46320) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:46320) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Should catch this error and display a more user friendly error message.

Here is a link that may help jestjs/jest#5311


I think this issue was mention before, but I couldn't find the issue relating to this one. Can close if it already exist.

@Immutablevoid Immutablevoid added the type: test Creation and development of test label Nov 9, 2019
@humphd
Copy link
Contributor

humphd commented Nov 9, 2019

See previous discussion in #116 (comment) and #48. CC @aprilllllllll

@aprilllllllll
Copy link
Contributor

Yes, I am working on this.

@Reza-Rajabi Reza-Rajabi moved this from Issue to In progress/Review in Main Nov 13, 2019
@humphd
Copy link
Contributor

humphd commented Dec 15, 2019

#494 (comment) is another example of the problem this needs to fix.

@agarcia-caicedo agarcia-caicedo added this to To do in 0.5 Release via automation Jan 13, 2020
Silvyre added a commit to Silvyre/telescope that referenced this issue Jan 19, 2020
Main automation moved this from In progress/Review to Closed Jan 22, 2020
0.5 Release automation moved this from To do to Done Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: test Creation and development of test
Projects
No open projects
0.5 Release
  
Done
Main
Closed
Development

Successfully merging a pull request may close this issue.

6 participants