Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch testing error and display a more user friendly error message. #122

Closed
ImmutableBox opened this issue Nov 9, 2019 · 3 comments · Fixed by #553
Closed

Catch testing error and display a more user friendly error message. #122

ImmutableBox opened this issue Nov 9, 2019 · 3 comments · Fixed by #553
Assignees
Labels

Comments

@ImmutableBox
Copy link
Collaborator

@ImmutableBox ImmutableBox commented Nov 9, 2019

Currently when running npm test you get this error if the Redis server is off:

(node:46320) UnhandledPromiseRejectionWarning: Error: connect ECONNREFUSED 127.0.0.1:6379
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1106:14)
(node:46320) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:46320) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Should catch this error and display a more user friendly error message.

Here is a link that may help facebook/jest#5311


I think this issue was mention before, but I couldn't find the issue relating to this one. Can close if it already exist.

@humphd

This comment has been minimized.

Copy link
Contributor

@humphd humphd commented Nov 9, 2019

See previous discussion in #116 (comment) and #48. CC @aprilllllllll

@Reza-Rajabi Reza-Rajabi added the on-board label Nov 9, 2019
@Reza-Rajabi Reza-Rajabi added this to Issue in Main via automation Nov 9, 2019
@aprilllllllll

This comment has been minimized.

Copy link
Contributor

@aprilllllllll aprilllllllll commented Nov 10, 2019

Yes, I am working on this.

@Reza-Rajabi Reza-Rajabi moved this from Issue to In progress/Review in Main Nov 13, 2019
@humphd

This comment has been minimized.

Copy link
Contributor

@humphd humphd commented Dec 15, 2019

#494 (comment) is another example of the problem this needs to fix.

@manekenpix manekenpix removed the on-board label Jan 13, 2020
@agarcia-caicedo agarcia-caicedo added this to To do in 0.5 Release via automation Jan 13, 2020
Silvyre added a commit to Silvyre/telescope that referenced this issue Jan 19, 2020
@humphd humphd closed this in #553 Jan 22, 2020
Main automation moved this from In progress/Review to Closed Jan 22, 2020
0.5 Release automation moved this from To do to Done Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Main
Closed
0.5 Release
  
Done
6 participants
You can’t perform that action at this time.