Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a reading time feature for the blog post #19

Closed
birtony opened this issue Oct 31, 2019 · 7 comments
Closed

Implement a reading time feature for the blog post #19

birtony opened this issue Oct 31, 2019 · 7 comments
Assignees
Labels
Projects

Comments

@birtony
Copy link
Contributor

birtony commented Oct 31, 2019

No description provided.

@humphd
Copy link
Contributor

humphd commented Nov 5, 2019

https://www.npmjs.com/package/reading-time probably does what we want.

@Reza-Rajabi Reza-Rajabi added this to Issue in Main Nov 6, 2019
@Reza-Rajabi
Copy link
Contributor

@birtony This issue already mentioned in #7 . Please consider closing this issue. If you decided to close this issue, that would be greate to address the @humphd 's above comment somewhere on #7 .

@birtony
Copy link
Contributor Author

birtony commented Nov 7, 2019

@Reza-Rajabi I believe that #7 is quite a generic issue, and it might be useful for us to split it into smaller parts to work on. However, thank you for referring it here, as both of them are definitely related.

@yohan-choi-dev
Copy link

@birtony For this issue, @humphd recommended a reading-time library that calculates not only reading time but also word count. If we can get the information about the level of vocabulary from a text, I think we can get a more precise reading time. Plus, if we can get the information for a reader's mother tongue, I guess we can get more precise reading time based on a user's language group or language distance from English. If you don't mind, I want to do this part.

@birtony
Copy link
Contributor Author

birtony commented Nov 7, 2019

@cyh0968 sure, sounds good! I have already started working on the word counter in #78, so now I am not sure if need it anymore?

@birtony birtony added area: back-end type: enhancement New feature or request labels Nov 7, 2019
@birtony birtony moved this from Issue to To do in Main Nov 7, 2019
@Reza-Rajabi Reza-Rajabi moved this from To do to In progress/Review in Main Nov 8, 2019
@yohan-choi-dev
Copy link

reading time = word count / the number of word per min
reading level = reading difficulty (the level of writing level) x reading time

I think they are highly coupled together, what about making them as one class? such as basic analysis?

@humphd
Copy link
Contributor

humphd commented Nov 13, 2019

@cyh0968 they can be combined eventually, but we have two people approaching the problem at once, and two pull requests with tests. Let's take both, and then refactor our code to include both tests, but share the implementation.

Main automation moved this from In progress/Review to Closed Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Main
Closed
Development

No branches or pull requests

6 participants