Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing writing level #84

Closed
lozinska opened this issue Nov 7, 2019 · 8 comments
Closed

Implementing writing level #84

lozinska opened this issue Nov 7, 2019 · 8 comments
Assignees
Labels
type: enhancement New feature or request
Projects

Comments

@lozinska
Copy link
Contributor

lozinska commented Nov 7, 2019

I would like to add feature to check the writing level

@lozinska lozinska added the type: enhancement New feature or request label Nov 7, 2019
@lozinska lozinska self-assigned this Nov 7, 2019
@Reza-Rajabi Reza-Rajabi added this to Issue in Main via automation Nov 8, 2019
@yohan-choi-dev
Copy link

you may refer this link. I think we can use reading-level to measure the level of the writing. you may refer issue 19. One thing I'm worried about is the duplication of the work since the level of the writing may affect the time of reading.

@Reza-Rajabi Reza-Rajabi moved this from Issue to In progress/Review in Main Nov 8, 2019
@lozinska
Copy link
Contributor Author

lozinska commented Nov 8, 2019

@cyh0968 Thank you for your comment. I think that reading-time and reading-level are part of the analysis that suppose to perform on the text mention in issue #7 and they are not a duplication of each others. This conclusion is based on the fact that reading time doesn't analyze the complexity of the text but just do rough estimation base on the plain text, while reading-level determine level base on the word complexity using Flesch-Kincaid Grade Level Readability Formula.
@cyh0968 what do you think?

@lozinska
Copy link
Contributor Author

lozinska commented Nov 8, 2019

@humphd please review if you have time and leave comment as well. Thank you

@humphd
Copy link
Contributor

humphd commented Nov 8, 2019

Reading Level and Reading Time are indeed different things. It's fine to do PRs for both (I think Reading Level is underway already).

This was referenced Nov 9, 2019
@dbeigi
Copy link
Contributor

dbeigi commented Nov 13, 2019

@lozinska is this feature still being worked on?

@lozinska lozinska assigned dbeigi and unassigned lozinska Nov 13, 2019
@lozinska
Copy link
Contributor Author

@dbeigi you can work on it

@dbeigi dbeigi removed their assignment Nov 14, 2019
@cheiaych
Copy link
Contributor

Is anyone working on this? If not, I can take it.

@cheiaych cheiaych self-assigned this Nov 26, 2019
Main automation moved this from In progress/Review to Closed Jan 14, 2020
@lozinska lozinska reopened this Jan 14, 2020
Main automation moved this from Closed to In progress/Review Jan 14, 2020
@lozinska
Copy link
Contributor Author

Reading level was implemented in PR 373 and merged into our code. As this issue had been resolved I will close it now. Thank you @jordanhui19 for your contribution for this nice feature.

Main automation moved this from In progress/Review to Closed Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
No open projects
Main
Closed
Development

No branches or pull requests

7 participants