Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some lines in the package.json file in /src/web need to be moved back to the top of the file #2816

Closed
cindyledev opened this issue Feb 3, 2022 · 2 comments · Fixed by #2878
Closed

Some lines in the package.json file in /src/web need to be moved back to the top of the file #2816

cindyledev opened this issue Feb 3, 2022 · 2 comments · Fixed by #2878
Assignees
@peterle93
Labels
5 min fix Fixable in 5 minutes or less developer experience Helping the Developer Experience good first issue Good for newcomers type: bug Something isn't working

Comments

@cindyledev
Copy link
Contributor

What happened:
As a side effect of #2795, the name, private, scripts, version properties were moved to the bottom of the file.

https://github.com/Seneca-CDOT/telescope/blob/master/src/web/package.json#L40-L47

What should have happened:

They should be at the top.

How to reproduce it (as precise as possible):

Anything else we need to know?:

Environment:

  • OS:
  • Browser:
@cindyledev cindyledev added type: bug Something isn't working good first issue Good for newcomers developer experience Helping the Developer Experience 5 min fix Fixable in 5 minutes or less labels Feb 3, 2022
@peterle93
Copy link
Contributor

can I take this issue?

@cindyledev
Copy link
Contributor Author

can I take this issue?

Sure. I'll assign you to the issue. Thanks for taking it on

@peterle93 peterle93 mentioned this issue Feb 10, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterle93 peterle93

Labels
5 min fix Fixable in 5 minutes or less developer experience Helping the Developer Experience good first issue Good for newcomers type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #2816 reorganize properties in web/package.json peterle93/telescope
2 participants
@cindyledev @peterle93