Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2793: Added mdx/react to web #2795

Conversation

AmasiaNalbandian
Copy link
Contributor

Issue This PR Addresses

Fixes #2793

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

After mdx-js latest update, there was some issues in our repository. After we read the docs and added mdx-js/react it seems to be stable.

Steps to test the PR

  • run pnpm i in root
  • Build in src/web
  • should build... and not show any errors.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Feb 2, 2022

@aserputov aserputov added Priority: High type: bug Something isn't working labels Feb 2, 2022
@manekenpix manekenpix changed the title Fixes 2793 - Added mdx/react to web Fixes #2793: Added mdx/react to web Feb 2, 2022
@AmasiaNalbandian AmasiaNalbandian merged commit 8f2ac63 into Seneca-CDOT:master Feb 2, 2022
@AmasiaNalbandian AmasiaNalbandian deleted the issue-2793-mdxjs-migration branch February 2, 2022 01:21
@humphd
Copy link
Contributor

humphd commented Feb 2, 2022

Well done, all of you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mdx packages breaking master
6 participants