Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESLint to lint all our JS/JSON #32

Closed
humphd opened this issue Nov 5, 2019 · 4 comments
Closed

Add ESLint to lint all our JS/JSON #32

humphd opened this issue Nov 5, 2019 · 4 comments
Projects

Comments

@humphd
Copy link
Contributor

@humphd humphd commented Nov 5, 2019

We should really have a proper automated linting step using ESLint. You can see good docs on how to do this at https://eslint.org/docs/user-guide/getting-started, and look at how lots of other projects do their linting by reading their .eslintrc file(s).

Until we get automated tests written, this can serve as our npm test step, and let us start automating CI in other bugs.

@humphd humphd mentioned this issue Nov 5, 2019
@kartik-budhiraja

This comment has been minimized.

Copy link
Contributor

@kartik-budhiraja kartik-budhiraja commented Nov 5, 2019

We can use Airbnb Javascript style guide as starting base and extend it. The eslint config is available through npm package eslint-config-airbnb-base.

@UltimaBGD

This comment has been minimized.

Copy link
Contributor

@UltimaBGD UltimaBGD commented Nov 5, 2019

In the event Airbnb style is something we are interested in, I will quickly put up a pull request with it setup for people to test with.

@Reza-Rajabi Reza-Rajabi added this to Issue in Main via automation Nov 6, 2019
@Reza-Rajabi Reza-Rajabi moved this from Issue to Review in progress in Main Nov 6, 2019
@UltimaBGD

This comment has been minimized.

Copy link
Contributor

@UltimaBGD UltimaBGD commented Nov 6, 2019

The pull request has been merged, shall we close this issue or keep it up for further discussion?

@humphd

This comment has been minimized.

Copy link
Contributor Author

@humphd humphd commented Nov 6, 2019

Close. Also, we should make sure that people use the "Fixes " style in their PRs so GitHub will auto-close issues fixed by PRs.

Thanks for working on this!

@humphd humphd closed this Nov 6, 2019
Main automation moved this from In progress/Review to Closed Nov 6, 2019
@Reza-Rajabi Reza-Rajabi added the on-board label Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Main
Closed
4 participants
You can’t perform that action at this time.