New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ESLint to lint all our JS/JSON #32
Comments
We can use Airbnb Javascript style guide as starting base and extend it. The eslint config is available through npm package |
In the event Airbnb style is something we are interested in, I will quickly put up a pull request with it setup for people to test with. |
The pull request has been merged, shall we close this issue or keep it up for further discussion? |
Close. Also, we should make sure that people use the "Fixes " style in their PRs so GitHub will auto-close issues fixed by PRs. Thanks for working on this! |
…rs-1.x fix(deps): update dependency http-errors to v1.8.1
We should really have a proper automated linting step using ESLint. You can see good docs on how to do this at https://eslint.org/docs/user-guide/getting-started, and look at how lots of other projects do their linting by reading their
.eslintrc
file(s).Until we get automated tests written, this can serve as our
npm test
step, and let us start automating CI in other bugs.The text was updated successfully, but these errors were encountered: