Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .ts and .tsx to prettier script in root package.json #3213

Closed
cindyledev opened this issue Mar 15, 2022 · 5 comments
Closed

Add .ts and .tsx to prettier script in root package.json #3213

cindyledev opened this issue Mar 15, 2022 · 5 comments
Assignees
Labels
5 min fix Fixable in 5 minutes or less area: front-end area: nextjs Nextjs related issues type: enhancement New feature or request
Milestone

Comments

@cindyledev
Copy link
Contributor

cindyledev commented Mar 15, 2022

We need to make our .ts and .tsx code pretty. Can't believe we haven't been using prettier for our .ts and .tsx

telescope/package.json

Lines 20 to 21 in 6439dbd

"prettier": "prettier --write \"./**/*.{md,jsx,json,html,css,js,yml}\"",
"prettier-check": "prettier --check \"./**/*.{md,jsx,json,html,css,js,yml}\"",

@cindyledev cindyledev added type: enhancement New feature or request area: front-end area: nextjs Nextjs related issues 5 min fix Fixable in 5 minutes or less labels Mar 15, 2022
@DukeManh
Copy link
Contributor

DukeManh commented Mar 15, 2022

Nice catch @cindyledev. The reason why our *.ts[x] files are still correctly formatted is that ESLint runs prettier as its own rule.

'prettier/prettier': 'error',

@cindyledev
Copy link
Contributor Author

I did some weird stuff last night with TypeScript and ESLint complained and prettier acted like it didn't know me

@1ibrahimhassan1
Copy link
Contributor

Hello

@humphd
Copy link
Contributor

humphd commented Mar 24, 2022

cc'ing @menghif, @tcvan0707, @JiaHua-Zou, @aserputov, who can lend support (they know this code well).

@cindyledev
Copy link
Contributor Author

Closed via #3316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 min fix Fixable in 5 minutes or less area: front-end area: nextjs Nextjs related issues type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants