Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3213: Add .ts and .tsx to prettier script in root package.json #3316

Merged
merged 1 commit into from Mar 24, 2022
Merged

Fixes #3213: Add .ts and .tsx to prettier script in root package.json #3316

merged 1 commit into from Mar 24, 2022

Conversation

1ibrahimhassan1
Copy link
Contributor

@1ibrahimhassan1 1ibrahimhassan1 commented Mar 24, 2022 •
edited

Issue This PR Addresses

Fixes issue #3213

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Added .ts and .tsx extensions to the prettier and prettier-check scripts within root package.json

Steps to test the PR

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Mar 24, 2022

@manekenpix manekenpix changed the title Added ts and tsx extensions to root prettier and prettier-check scripts Fixes #3213: Add .ts and .tsx to prettier script in root package.json Mar 24, 2022
@manekenpix manekenpix added the developer experience Helping the Developer Experience label Mar 24, 2022
@manekenpix manekenpix merged commit e245ac3 into Seneca-CDOT:master Mar 24, 2022
@1ibrahimhassan1 1ibrahimhassan1 deleted the prettier-change branch March 24, 2022 22:59
@cindyledev cindyledev mentioned this pull request Mar 24, 2022
Closed
@humphd
Copy link
Contributor

humphd commented Mar 25, 2022

Thanks @1ibrahimhassan1. Ping me on Slack if you want to work on something bigger.

@cindyledev cindyledev added this to the 2.9 Release milestone Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cindyledev cindyledev cindyledev approved these changes

@AmasiaNalbandian AmasiaNalbandian AmasiaNalbandian approved these changes

Assignees

@1ibrahimhassan1 1ibrahimhassan1

Labels
developer experience Helping the Developer Experience
Projects
None yet
Milestone
2.9 Release
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@1ibrahimhassan1 @humphd @cindyledev @AmasiaNalbandian @manekenpix