Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for /feed/* routes #638

Closed
humphd opened this issue Feb 1, 2020 · 0 comments · Fixed by #670
Closed

Add tests for /feed/* routes #638

humphd opened this issue Feb 1, 2020 · 0 comments · Fixed by #670
Assignees
@Silvyre
Labels
area: web server Issues related to the web server type: enhancement New feature or request type: test Creation and development of test
Projects
0.6 Release: Grade A Dogfood

Comments

@humphd
Copy link
Contributor

humphd commented Feb 1, 2020

What would you like to be added:

Add tests for all the routes under /feed/*, including:

  • /feed/rss
  • /feed/atom
  • /feed/json
  • /feed/wiki

NOTE: the /feed/opml tests are being done in #595.

These tests can make sure that we return something of the right Content-Type, with the correct HTTP Status Code, and that we get a body that roughly matches what we expect (this can be pretty basic).

Why would you like this to be added:

In #633 we added all these routes, but didn't write any tests. This will fix that.
@humphd humphd added type: enhancement New feature or request type: test Creation and development of test area: web server Issues related to the web server labels Feb 1, 2020
@humphd humphd mentioned this issue Feb 1, 2020
Merged
4 tasks
@Silvyre Silvyre mentioned this issue Feb 3, 2020
Merged
8 tasks
@Silvyre Silvyre added this to To do in 0.6 Release: Grade A Dogfood via automation Feb 5, 2020
@Silvyre Silvyre moved this from To do to In progress in 0.6 Release: Grade A Dogfood Feb 5, 2020
Silvyre added a commit to Silvyre/telescope that referenced this issue Feb 7, 2020
@Silvyre
Issue Seneca-CDOT#638 add Jest tests for /feed/* endpoints
1f355d0
@Silvyre Silvyre mentioned this issue Feb 7, 2020
Merged
8 tasks
0.6 Release: Grade A Dogfood automation moved this from In progress to Done Feb 8, 2020
humphd pushed a commit that referenced this issue Feb 8, 2020
@Silvyre
Issue #638 add Jest tests for /feed/* endpoints (#670)
f6253bf 
* Issue #638 add Jest tests for /feed/* endpoints

* add structural test for wiki feeds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Silvyre Silvyre

Labels
area: web server Issues related to the web server type: enhancement New feature or request type: test Creation and development of test
Projects
No open projects
0.6 Release: Grade A Dogfood
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #638 add Jest tests for /feed/* endpoints Silvyre/telescope
2 participants
@humphd @Silvyre