Enhancement (HTML/jS): modified the website #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CSS/HTML/JS updates for optimization of static webpage Fixes Seneca-CDOT#61 enhancement (folders): Front-End Folder made
ODAVING
requested review from
jerryshueh,
lucacataldo,
dbeigi,
wajeehsheikh,
eekbatani,
MusaBajwa and
KarlaChen
MusaBajwa
approved these changes
Nov 8, 2019
eekbatani
approved these changes
Nov 8, 2019
KarlaChen
reviewed
Nov 8, 2019
|
|
||
| } | ||
| /* Regular Theme ends */ | ||
|
|
There was a problem hiding this comment.
Add the below code to avoid horizontal scroll.
html{
overflow-x: hidden;
}
There was a problem hiding this comment.
The overflow was supposed to be there for future mobile views, if this gets improved over the next week, then some more changes can be done 😄
|
@ODAVING this looks great man! |
|
Got it.
On Fri, Nov 8, 2019 at 4:15 PM Sina Lahsaee ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In planet.css
<#104 (comment)>:
> @@ -1,151 +1,241 @@
+/* Regular theme starts */
+.normalTheme{
+ --main-bg-color: #ffffff;
+ --nav-font-color: #b51418;
+ --box-shadow-color: rgba(221, 220, 220, 0.911);
+ --nav-btn-bgcolor: #ffffff;
+ --close-btn-hover: #d85f61;
+ --content-font: #000000;
+ --title-border: #a0a0a0d8;
+
+}
+/* Regular Theme ends */
+
The overflow was supposed to be there for future mobile views, if this
gets improved over the next week, then some more changes can be done 😄
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#104?email_source=notifications&email_token=ALKUOYKM7N4FRERMIKMLUT3QSXJH5A5CNFSM4JKTIWF2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCK7FMXY#discussion_r344369481>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALKUOYIRL4UXTJUICCAWW5DQSXJH5ANCNFSM4JKTIWFQ>
.
--
Karla Chan/ Karlita
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSS/HTML/JS updates for optimization of static webpage
Fixes #61
If you'd like to preview the website, here it is: https://odaving.github.io/telescope/