Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement (HTML/jS): modified the website #104

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@ODAVING
Copy link
Contributor

ODAVING commented Nov 8, 2019

CSS/HTML/JS updates for optimization of static webpage

Fixes #61

If you'd like to preview the website, here it is: https://odaving.github.io/telescope/

CSS/HTML/JS updates for optimization of static webpage

Fixes #61

enhancement (folders): Front-End Folder made
Copy link
Contributor

MusaBajwa left a comment

Looks great. Good job Sina.

Copy link
Contributor

eekbatani left a comment

Looks real good, well done!

@eekbatani eekbatani merged commit 5c27e1f into Seneca-CDOT:master Nov 8, 2019
Copy link
Contributor

KarlaChen left a comment

Everything is good, just add some code to avoid the horizontal scroll bar cause I think we don't need it.


}
/* Regular Theme ends */

This comment has been minimized.

Copy link
@KarlaChen

KarlaChen Nov 8, 2019

Contributor

Add the below code to avoid horizontal scroll.
html{
overflow-x: hidden;
}

This comment has been minimized.

Copy link
@ODAVING

ODAVING Nov 8, 2019

Author Contributor

The overflow was supposed to be there for future mobile views, if this gets improved over the next week, then some more changes can be done 😄

@Reza-Rajabi Reza-Rajabi added this to In progress/Review in Main via automation Nov 9, 2019
@Reza-Rajabi Reza-Rajabi added the on-board label Nov 9, 2019
@ragnarokatz

This comment has been minimized.

Copy link
Collaborator

ragnarokatz commented Nov 9, 2019

@ODAVING this looks great man!

@KarlaChen

This comment has been minimized.

Copy link
Contributor

KarlaChen commented Nov 9, 2019

@Reza-Rajabi Reza-Rajabi moved this from In progress/Review to Done in Main Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.