Fixes #83: test case for text-parser

[giatuongtran9]

Adding test case for parsing html to text, reference to issue #75

@PavanKKamra, apparently JSOM does not support innetText, based on this Issue. I have tested it and innerHTML and textContent works fine but innerText will return 'undefined'

[humphd]

Excellent research on this. I hadn't known about the innerText issue in jsdom. I agree that we can probably just use textContent instead.

This looks like a good start, but can you update your tests to do a few things:

1. include some HTML that would produce newlines (e.g., h1 and p) and make sure they work as we'd expect.
2. assume that textParser.run() returns a Promise vs. something we get back directly.

[giatuongtran9]

Hi @humphd , I have change the test to return a Promise by async await.

I have noticed that dialogue.js has some errors whenever I run the test 'npm run test'

[humphd]

@giatuongtran9 there is a PR to fix that in #106 if you want to review.

[cindyledev]

PR #106 fixes the linting errors in the dialogue.js file so you just need to rebase and resolve the path to module

[humphd]

@giatuongtran9 it looks like you've merged and pulled in a bunch of unrelated changes. Also, there are merge conflict markers in test/text-parser.test.js.

NOTE: you want to rebase but not merge with master.

[giatuongtran9]

@humphd I made some mistakes at the beginning and try to rebase to master but somehow pulled all the new files. The test fail because we don't have the text-parser.js yet

[humphd]

OK, we'll have to fix this git history. I can help you when we see each other at the start of the week, or you can try and do it yourself between now and then.

As far as the failure, tell Jest to skip these tests until we have an implementation: https://jestjs.io/docs/en/api.html#testskipname-fn

[giatuongtran9]

I will try to fix this but I think I will need your help. skip cannot be used here because the test need the run method from text-parser.js so we can comment out the test or do this for now:

expect('Hello World').toBe('Hello Word');

[humphd]

OK @giatuongtran9, how about this. Since @PavanKKamra doesn't seem to have started his work yet, why don't you add text-parser.js and have it export a function at least. In the code, you can leave a comment to the Issue that will implement it in #75. Then @PavanKKamra can work from there.

@PavanKKamra how is your work coming? It sounds like we're just about ready for your code here...

[giatuongtran9]

@humphd I have added simple function for text-parser and @PavanKKamra can continue from there

[humphd]

Looks good.

[humphd]

@giatuongtran9 you need to regenerate package-lock.json like so:

npm install
git add package-lock.json

[giatuongtran9]

@humphd Thank you and @cindyledev please review it again

[humphd]

Good stuff.

[giatuongtran9]

@cindyledev please review again, if you left it here, other stuff will get merged and this will forever get conflict and never get merge
@humphd sorry for asking to review it again so many time

[manekenpix]

There's a big amount of unrelated changes here. Try to get rid of them.