Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #44: Added Github Actions CI for redis run, npm install and test #126

Closed
wants to merge 2 commits into from

Conversation

sukhbeersingh
Copy link
Contributor

This PR adds a basic Github Action to do the following

  1. Checkout the code from git
  2. Run docker image of redis
  3. Run basic npm commands: npm ci, npm run eslint and npm run jest

This is triggered every time someone makes a push to the master branch. I think that should be enough for now. We can probably add checks on each pull request made to the master, I am not sure if that'd be too much. Thoughts?

I tested on my repo. The telescope repo doesn't show an Actions tab. It is be free for all public repositories. Maybe when the code is pushed the button appears?

@sukhbeersingh sukhbeersingh added the area: CI/CD Continuous integration / Continuous delivery label Nov 9, 2019
@Reza-Rajabi Reza-Rajabi added this to In progress/Review in Main via automation Nov 9, 2019
@cindyledev cindyledev self-requested a review November 9, 2019 22:37
@kartik-budhiraja
Copy link
Contributor

@sukhbeersingh As GH actions is in beta stage, we have to sign up for it and then GH sends an email for confirmation and the actions tab shows up.
I guess you would need admin access for signing up.
cc:@humphd can help us out here.

@humphd
Copy link
Contributor

humphd commented Nov 10, 2019

@sukhbeersingh @kartik-budhiraja I tried today to sign up with this CDOT org, and it complained. I've asked on twitter for clarification about what's up with this account type--we may not be able to do it without a personal account during the beta. Let's hope that's wrong...

@humphd
Copy link
Contributor

humphd commented Nov 11, 2019

@sukhbeersingh I spoke with GitHub support, and the account type that CDOT has can't be used with the GitHub Actions Beta program :(

I'm going to close this, but honour your work toward the project (please submit as part of your 0.3). Did you want to try working on another CI provider?

@humphd humphd closed this Nov 11, 2019
Main automation moved this from In progress/Review to Closed Nov 11, 2019
@sukhbeersingh
Copy link
Contributor Author

@humphd I see that this repo now has the Actions tab. Do we want to try setting up Github Actions then?

@sukhbeersingh sukhbeersingh reopened this Nov 16, 2019
Main automation moved this from Closed to In progress/Review Nov 16, 2019
@humphd
Copy link
Contributor

humphd commented Nov 16, 2019

@sukhbeersingh I clicked on the link, and here is what I see:

Screen Shot 2019-11-16 at 1 01 49 PM

:(

Main automation moved this from In progress/Review to Closed Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: CI/CD Continuous integration / Continuous delivery
Projects
No open projects
Main
Closed
Development

Successfully merging this pull request may close these issues.

None yet

5 participants