Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1272: Redis link causing confusion in environment setup (Docs) #1273

Merged
merged 3 commits into from
Nov 2, 2020
Merged

Fixes #1272: Redis link causing confusion in environment setup (Docs) #1273

merged 3 commits into from
Nov 2, 2020

Conversation

HyperTHD
Copy link
Contributor

@HyperTHD HyperTHD commented Nov 2, 2020

Issue This PR Addresses

Fixes #1272

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

In the environment setup document file, when setting up redis using WSL2, one of the steps involved the process of compiling and installing redis. The much more simpler method is to use the package manager of the linux distribution you use for installing redis. For example, using "sudo apt-get install redis-server" with an ubuntu distribution. The environment-setup documentation was therefore, updated to reflect this.

For reference, this was the link with the installation issue with installing redis

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

humphd
humphd previously approved these changes Nov 2, 2020
@manekenpix manekenpix added area: redis Redis Database related type: documentation (docs) Improvements or additions to documentation labels Nov 2, 2020
@manekenpix manekenpix added this to In progress in Documentation via automation Nov 2, 2020
Copy link
Member

@manekenpix manekenpix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's another mention of that url in line 8 in the same document.
Could you get rid of it, and maybe link that line to line 16?

Documentation automation moved this from In progress to Review in progress Nov 2, 2020
Copy link
Member

@manekenpix manekenpix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Documentation automation moved this from Review in progress to Reviewer approved Nov 2, 2020
Copy link
Contributor

@cindyledev cindyledev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

@manekenpix manekenpix merged commit 9f71e65 into Seneca-CDOT:master Nov 2, 2020
Documentation automation moved this from Reviewer approved to Done Nov 2, 2020
@HyperTHD HyperTHD deleted the issue-1272 branch March 31, 2021 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: redis Redis Database related type: documentation (docs) Improvements or additions to documentation
Projects
No open projects
Documentation
  
Done
Development

Successfully merging this pull request may close these issues.

Redis link causing confusion in environment setup (Docs)
4 participants