Fixes #73: Updated README and CONTRIBUTING #132
Conversation
|
This has too many unrelated commits in here, I assume from a merge? Please rebase PRs instead of merging master into them. |
|
I got rid of the unrelated commits |
manekenpix
added
the
type: documentation (docs)
| ``` | ||
| # Could not create server TCP listening socket *:6379: bind: Address already in use | ||
| ``` | ||
| 1. Run `sudo systemctl status redis` to check if the service is running |
There was a problem hiding this comment.
This is unnecessary. Regular users should not have to access systemctl in this scenario. We are creating a docker container so errors addressed in this section should pertain to those that could be had from running redis in a docker container. Please read #135 for more information.
| user 2570 0.0 0.0 253100 4908 pts/1 Sl+ 13:11 0:00 redis-server *:6379 | ||
| user 2588 0.0 0.0 215744 888 pts/0 S+ 13:16 0:00 grep --color=auto redis | ||
| ``` | ||
| Run `sudo kill -9 2570` |
There was a problem hiding this comment.
Again, this is unnecessary. See my comment above. FYI the process ID that you have added will likely not be the same for others running the same process. Suggesting an uninformed user to execute kill -9 with sudo on a specific pid like you are suggesting here is dangerous and could cause some major issues on their machine.
|
Hey @cindyledev - there was some interesting work here and I'm sad to see that you closed your patch 😔I'd like to pair and continue improving the contributing docs, if you're up for it! Feel free to message me on slack - my username is |
Updated README.md and CONTRIBUTING.md with
Ref #73 . Do not close this issue as @MusaBajwa is also assigned to it.