Port Footer to NextJS #1526
Port Footer to NextJS #1526
Conversation
| @@ -0,0 +1,207 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
With next.js you don't need to import React
|
So 9a73f4f contains just the footer code. As that component is a standalone component compared to the AboutFooter and Banner component, I'd like to consider maybe having the other two in it's own PR just so we can have all standalone components merged. Leave your thoughts |
| @@ -1,4 +1,5 @@ | |||
| import Head from 'next/head'; | |||
| import Footer from '../components/Footer/index'; | |||
There was a problem hiding this comment.
Change this to import Footer from '../components/Footer'; and the styling should be applied properly
netlify.toml
Outdated
|
|
||
|
|
||
| [build.environment] | ||
| API_URL="https://dev.telescope.cdot.systems" |
There was a problem hiding this comment.
Why is this change in your PR?
| @@ -0,0 +1,3 @@ | |||
| import Footer from './Footer'; | |||
There was a problem hiding this comment.
This is a .ts not a .tsx file.
src/frontend/next/package.json
Outdated
| @@ -4,7 +4,7 @@ | |||
| "private": true, | |||
| "scripts": { | |||
| "dev": "next dev -p 8000", | |||
| "build": "next build", | |||
| "build": "next build && next export", | |||
There was a problem hiding this comment.
Do we need to modify the build command for the frontend? I think this might break something, or at least delay deployment times due to the export. Let me know!
HyperTHD
changed the title
|
It looks like Netlify is unhappy: |
Issue This PR Addresses
Fixes #1454
Type of Change
Description
This PR is a part of the transition for the telescope frontend from gatsby, to next. As part of this transition, this PR addresses the porting of the Footer component to NextJS.
Expected Output:
Checklist