[next] Fixes #1539: Porting DeleteFeedDialogButton to Next #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyperTHD
requested review from
birtony,
chrispinkney,
humphd,
PedroFonsecaDEV and
tonyvugithub
HyperTHD
added
area: front-end
area: nextjs
humphd
previously approved these changes
Jan 21, 2021
| const { id, url } = feed; | ||
| const classes = useStyles(); | ||
| const { telescopeUrl } = useSiteMetadata(); | ||
| const [open, setOpen] = useState<boolean>(false); |
There was a problem hiding this comment.
For inferred types like this, it's not necessary to include the generic <boolean>. Not wrong to do this, but not necessary.
| const { telescopeUrl } = useSiteMetadata(); | ||
| const [open, setOpen] = useState<boolean>(false); | ||
|
|
||
| const deleteBtnRef = useRef<HTMLButtonElement>(null); |
There was a problem hiding this comment.
Whereas this one is necessary, since we can't infer from null.
| const removeFeed = async () => { | ||
| console.log(`Removing feed hosted at URL ${url}...`); | ||
| try { | ||
| const response = await fetch(`${telescopeUrl}/feeds/${id}`, { method: 'DELETE ' }); |
There was a problem hiding this comment.
Stupid question but 'DELETE ' has an extra space in it, is it needed?
There was a problem hiding this comment.
Definitely not, that's my fast typing lol
|
Also, is there any way to test this code? I imagine not right? |
|
Not atm, this will need to be imported onto the corresponding components that use it in order to see if there's anything wrong with it |
tonyvugithub
approved these changes
Jan 22, 2021
chrispinkney
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue This PR Addresses
Fixes #1539
Type of Change
Description
This PR address #1539, which is the porting of the DeleteFeedDialogIcon button to next from gatsby. It is part of #1316 which is the transitioning of the telescope frontend.
Checklist