Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1534, Added Legacy Dependencies Check #1694

Merged
merged 1 commit into from Feb 11, 2021

Conversation

Metropass
Copy link
Contributor

Issue This PR Addresses

Type of Change

Fixes #1534
and closed #1617 due to the branch being outdated

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

As of npm7.x, Peer Dependencies has had an overhaul, causing some of our dependencies not properly installing if a user runs npm install. This is a band-aid fix to use the legacy Peer Dependencies, until we fix the issue for forwards compatibility.

This is a final version of #1617, as this PR is rebased.

More Information on the Changes of Peer Dependencies can be found here

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@HyperTHD
Copy link
Contributor

cc @chrispinkney

@HyperTHD HyperTHD added the developer experience Helping the Developer Experience label Feb 11, 2021
@HyperTHD HyperTHD added this to the 1.7 Release milestone Feb 11, 2021
Copy link
Contributor

@chrispinkney chrispinkney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. From the (very minor) research I've done on this topic, it doesn't seem like this will cause doom and panic across our repo.

I guess this will be fine to remove in a few years when conflicting peer dependencies are a thing of the past? 🤷

Copy link
Contributor

@birtony birtony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! #1647 should help with updating our dependencies

@Metropass Metropass merged commit b9371a3 into Seneca-CDOT:master Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer experience Helping the Developer Experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node Version 15+ Does Not Install Dependecies Properly
4 participants