Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1252, Added Comments for Logger Discussion #1782

Merged
merged 1 commit into from Feb 19, 2021
Merged

Fixes #1252, Added Comments for Logger Discussion #1782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/backend/feed/processor.js
View file
Open in desktop
Expand Up @@ -207,7 +207,7 @@ module.exports = async function processor(job) {
}`
);
} else {
logger.error({ error }, `Unable to process feed ${feed.url}`);
logger.debug({ error }, `Unable to process feed ${feed.url}`);
throw error;
}
}
Expand Down
5 changes: 3 additions & 2 deletions src/backend/feed/worker.js
View file
Open in desktop
Expand Up @@ -31,9 +31,10 @@ exports.start = async function () {
try {
await waitOnReady();
logger.info('Connected to elasticsearch!');

const concurrency = getFeedWorkersCount();
logger.info(`Starting ${concurrency} instance${concurrency > 1 ? 's' : ''} of feed processor.`);
logger.debug(
`Starting ${concurrency} instance${concurrency > 1 ? 's' : ''} of feed processor.`
);
feedQueue.process(concurrency, path.resolve(__dirname, 'processor.js'));
return feedQueue;
} catch (error) {
Expand Down
6 changes: 3 additions & 3 deletions src/backend/lib/shutdown.js
View file
Open in desktop
Expand Up @@ -11,7 +11,7 @@ async function stopQueue() {
await feedQueue.close();
logger.info('Feed queue shut down.');
} catch (error) {
logger.error({ error }, 'Unable to close feed queue gracefully');
logger.debug({ error }, 'Unable to close feed queue gracefully');
}
}

Expand All @@ -24,7 +24,7 @@ async function stopWebServer() {
await serverClose();
logger.info('Web server shut down.');
} catch (error) {
logger.error({ error }, 'Unable to close web server gracefully');
logger.debug({ error }, 'Unable to close web server gracefully');
}
}

Expand All @@ -33,7 +33,7 @@ async function cleanShutdown() {
await Promise.all([stopQueue(), stopWebServer()]);
logger.info('Completing shut down.');
} catch (error) {
logger.error({ error }, 'Failed to perform clean shutdown');
logger.debug({ error }, 'Failed to perform clean shutdown');
}
}

Expand Down