New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Initial Service to Get Posts #1838
Conversation
This PR is not tested btw. I'm still working on the Docker related stuff. I will post screenshots of the output when I get it working |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UPDATE:
Running the posts service atm loads the right page, however, NO POSTS ARE LOCATED AND YOU GET AN EMPTY ARRAY AS A RESULT. I feel this is because of the changed host names, since the redis data is locally served instead of via the cloud. I'm not too sure about this one. Otherwise, I feel good about this service and can move to add in the extra routes. As for adding test cases for this microservice, I plan on filing another issue to handle that. I want this PR strictly for porting this microservice over |
src/api/docker-compose.yml
Outdated
- ${REDIS_PORT}:${REDIS_PORT} | ||
command: ['redis-server', '--appendonly', 'yes'] | ||
volumes: | ||
- ../../../redis-data:/data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder where we should put volumes related to the microservices. The root is one option for sure, but maybe we should have a dedicated directory where we can find these things. cc @manekenpix, @raygervais.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@humphd this is how we currently do it on prod
and dev
:
@manekenpix I left a similar review comment, a lot of this code can get deleted. |
@manekenpix @humphd The main problem with removing that code is that there's no way for me to really know if the service works or not. The files related to my service also require the other files needed for feeds as well. Since we don't have those other services up, I can't realistically remove those extra files without breaking CI |
Why not test using mock services to pass in hypothetical data @HyperTHD ? |
Requested changes were completed, awaiting final review
Issue This PR Addresses
This PR address #1735
Type of Change
Description
This PR is a work-in-progress, meant to work on adding a Post Microservice. This microservice parses posts from user's feeds and returns them. There's a path that returns the 10 latest posts, and you can also retrieve information about a specific post using it's ID.
This PR includes files that are being used by other microservices. I recommend getting those PRs in first before this one so that I can update the docker-compose file to use those services. This would allow me to remove the files those services used and only keep what I need for my microservice. In particular, this would be the User Microservice, The Post parsing microservice (#1828), and possibly the Feed Parsing microservice (#1833).
UPDATE: Screenshot of successful loading of this route along with network tab open as proof
Checklist