Use proper AUTH_URL values in next.config.js and AuthProvider #1954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humphd
added
area: docker
area: deployment
| @@ -28,7 +28,7 @@ API_VERSION=v1 | |||
| # Auth Service | |||
| ################################################################################ | |||
|
|
|||
| # Auth Service Port (default is 4444) | |||
| # Auth Service Port (default is 7777) | |||
There was a problem hiding this comment.
Doesn't feed discovery use 7777?
There was a problem hiding this comment.
It did, but I've now updated it. We had two servers on the same port (auth was always on 7777 so it wasn't available when Tony chose it).
Deal with conflicting port 7777
|
Rebased to pickup the posts changes on master, I need two more reviews? I'd love to get this in soon. |
manekenpix
approved these changes
Mar 16, 2021
HyperTHD
approved these changes
Mar 16, 2021
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@manekenpix and @HyperTHD noticed a few bugs in the way the staging auth fix was being done. This corrects the problems by properly defining the
AUTH_URLfor next's build, and using it in theAuthProvider.