Fix #115: added test cases for sentiment analysis #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
November 14, 2019 23:18
manekenpix
requested changes
Nov 15, 2019
manekenpix
requested changes
Nov 15, 2019
humphd
reviewed
Nov 15, 2019
|
|
||
| test('test if sample text does not return the correct object', async () => { | ||
| const data = await sentimentAnalysis.run('I like dogs, but my girlfriend is afraid of them'); | ||
| expect(data).toEqual(expect.not.objectContaining(expected)); |
There was a problem hiding this comment.
Why do you not just compare data to expected with a deep equals here? What does .toEqual(expect.not.objectContaining(expected)) mean? Maybe you're right, but this seems odd.
There was a problem hiding this comment.
@humphd From what I have read, .toEqual should be used for objects. Regards to expect.not.objectContaining(expected) , I am using this to check if the contents(properties) of the object do not match what we are expecting. This was suggested by @jatinAroraGit and after reading the docs I agreed to his suggestion.
There was a problem hiding this comment.
Interesting, OK, sounds fine. Thanks for educating me.
humphd
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to address #115 . I wrote two test cases that will test if sentiment analysis functionality will a) return the unexpected object b) return the expected object.
@jatinAroraGit would love to see your feedback on the following tests.