Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2299: No margin between author name and date #2336

Merged
merged 1 commit into from Oct 6, 2021

Conversation

lyu4321
Copy link
Contributor

@lyu4321 lyu4321 commented Oct 4, 2021

Issue This PR Addresses

Closes #2299

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

This PR adds a uniform margin between author name and date regardless of author name length.

Before:
image

image

After:
image

image

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@lyu4321 lyu4321 changed the title Closes #2299 Closes #2299: No margin between author name and date Oct 4, 2021
humphd
humphd previously approved these changes Oct 4, 2021
@manekenpix manekenpix added this to In progress in UI and Frontend via automation Oct 5, 2021
@manekenpix manekenpix added this to the 2.1.5 Release milestone Oct 5, 2021
@manekenpix
Copy link
Member

@lyu4321 can you rebase on master?

@humphd
Copy link
Contributor

humphd commented Oct 5, 2021

@lyu4321

git checkout master
git pull upstream master
git checkout issue-2299
git rebase master
git push origin issue-2299 -f

UI and Frontend automation moved this from Review in progress to Reviewer approved Oct 6, 2021
@humphd humphd merged commit 4d3de98 into Seneca-CDOT:master Oct 6, 2021
UI and Frontend automation moved this from Reviewer approved to Done Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

No margin between author name and date
3 participants