Fix #2415: add live build logs in status dashboard #2455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Andrewnt219
force-pushed
the
2415-add-live-build-logs
branch
from
19e812d
to
45e40cb
Compare
Andrewnt219
changed the title
Andrewnt219
force-pushed
the
2415-add-live-build-logs
branch
from
45e40cb
to
c660380
Compare
Andrewnt219
force-pushed
the
2415-add-live-build-logs
branch
from
c660380
to
3cbb451
Compare
humphd
requested changes
Nov 10, 2021
humphd
previously approved these changes
Nov 11, 2021
|
@Andrewnt219 can you squash/rebase this for me? I think it's basically ready. I just want one more review on it. cc @manekenpix, in case you want to read it before it goes in. |
port build log from React version move scripts down remove protocol refactor autodeploymentUrl remove class from body
Andrewnt219
force-pushed
the
2415-add-live-build-logs
branch
from
8f58dd2
to
29d8141
Compare
humphd
approved these changes
Nov 11, 2021
|
This's just the first step. Let's deploy it to see if it's everything's working and I'll continue to iterate over this feature until it's finished 👍. |
manekenpix
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue This PR Addresses
Closes #2415
Type of Change
Description
On /build.html, periodically fetches build status and shows build logs (if any) using xterm.
Test plan
To test locally, change to
<base href="/" />inside build.html and run start script. The site is onlocalhost:1111/pages/build.html.Xterm UI should show up. In the dev console,
/statusis requested periodically.Checklist