Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes issue-2446 #2459

Merged
merged 1 commit into from Nov 10, 2021
Merged

fixes issue-2446 #2459

merged 1 commit into from Nov 10, 2021

Conversation

ycechungAI
Copy link

@ycechungAI ycechungAI commented Nov 10, 2021

Issue This PR Addresses

#2446

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

All the new Github links that we added open in a new page but clicking on the blogger's name or the date opens links in the current.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Nov 10, 2021

@ycechungAI ycechungAI merged commit 2ca5e46 into Seneca-CDOT:master Nov 10, 2021
@humphd
Copy link
Contributor

humphd commented Nov 10, 2021

@ycechungAI NOTE: we typically want 2 reviews before we marge things.

@humphd
Copy link
Contributor

humphd commented Nov 10, 2021

The reason for this is so that we spread knowledge of a change over more devs on the team.

@ycechungAI
Copy link
Author

is there a way to undo this? or reopen it for another reviewer?

@humphd
Copy link
Contributor

humphd commented Nov 10, 2021

Don't worry, it's OK. We could git revert anything we don't want to merge, but it's best to over communicate when landing things, since sometimes order matters, sometimes we need to wait on other things to land first, sometimes we need to fix commit history before landing, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants