Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update traefik version #2495

Merged
merged 2 commits into from Nov 19, 2021
Merged

update traefik version #2495

merged 2 commits into from Nov 19, 2021

Conversation

Qiwen-Yu
Copy link
Contributor

@Qiwen-Yu Qiwen-Yu commented Nov 19, 2021 •
edited by gitpod-io bot

Issue This PR Addresses

Fix issue #2424

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Nov 19, 2021

sirinoks
sirinoks approved these changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@sirinoks sirinoks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't break on my end, looks good

humphd
humphd approved these changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on GitPod, works.

@humphd humphd merged commit bff7a86 into Seneca-CDOT:master Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humphd humphd humphd approved these changes

@sirinoks sirinoks sirinoks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Qiwen-Yu @humphd @sirinoks