Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2240: drop node-fetch in apis #2524

Merged
merged 1 commit into from Nov 26, 2021

Conversation

tuanthanh2067
Copy link
Contributor

Issue This PR Addresses

Fixes #2240

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Drop all node-fetch to use fetch from satellite

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Nov 25, 2021

@tuanthanh2067
Copy link
Contributor Author

Hi I dropped all node-fetch from apis.

image

humphd
humphd previously approved these changes Nov 26, 2021
@humphd humphd requested a review from HyperTHD November 26, 2021 00:46
HyperTHD
HyperTHD previously approved these changes Nov 26, 2021
Copy link
Contributor

@HyperTHD HyperTHD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Checked each file, looks good to merge

@HyperTHD
Copy link
Contributor

Just make sure you rebase this first @tuanthanh2067

@humphd
Copy link
Contributor

humphd commented Nov 26, 2021

@tuanthanh2067 please do:

git checkout master
git pull upstream master
git checkout issue-2240
git rebase master
git push origin issue-2240 -f

And then we can merge it.

@humphd humphd merged commit 261daa8 into Seneca-CDOT:master Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Satellite's fetch() function and remove local deps for microservices
3 participants