Adding /feeds/delayed route to Posts service, adding test in posts/te… #2575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
humphd
reviewed
Dec 7, 2021
src/api/posts/src/storage.js
Outdated
| const delayedKeys = await getFeedKeysUsingScanStream(`${feedNamespace}*${delayedSuffix}`); | ||
| return Promise.all( | ||
| delayedKeys.map(async (key) => { | ||
| const timeLeft = await redis.ttl(key); |
There was a problem hiding this comment.
I can't decide if we need this info or not. The fact that it will require so many extra async calls to Redis makes me want to say that we don't. Just knowing that it's delayed is probably enough? What's your thinking?
There was a problem hiding this comment.
Yeah, I think we should not have this timeLeft infor. we don't use it for anything. I will remove it and fix the test. Thank you :)
humphd
previously approved these changes
Dec 9, 2021
AmasiaNalbandian
previously approved these changes
Dec 9, 2021
|
@hphan9 please squash and rebase this. |
* Adding functions in posts/src/route/feeds.js, adding test in posts/test/feeds.test.js, fixing the setDelayedFeeds function in posts/src/storage.js and backend/utils/storage.js * removing timeLeft infor in getDelayedFeeds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…st/feeds.test.js, fixing the setDelayedFeeds function in posts/src/storage.js and backend/utils/storage.js
Issue This PR Addresses
Fixes #2413
Type of Change
Description
I added a new route /feeds/delayed to Posts service. I also fixed the small bug in the setDelayedFeed function to set a time for expiry in seconds. Thank you and please review my pull request.
Checklist