New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified regex to match user only #2751
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Work @Kevan-Y 💯
Look at this:
The link I hover on here is from michaels repository (you can see link at bottom left):
That link adds both himself under users, and his repository under respository.
Edge case found,
Those will still be able to display in the Github info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the sort of thing that is so easy to test, we should add some for filterGitHubUrls
in a follow-up.
Don't very have a good solution right now besides hardcoded. Like have a list of reserved names, and do a check before adding to the list of repo or org. The second solution is to call GitHub API to check one by one but might run out of the limit in a sec. |
I don't think we should call the GitHub API. Having a list of ones we know are static endpoints would work. It doesn't need to be perfect, just "better". |
08d52fc
to
2ee8359
Compare
2ee8359
to
d959f0f
Compare
@humphd can we merge this one ? |
9ed1e88
d959f0f
to
9ed1e88
Compare
Issue This PR Addresses
Fixes #2707
Type of Change
Description
Modified the regex that filters GitHub URL to find GitHub Users tagged in posts to be shown under user/organization
Before
After
Checklist