New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 274 Add pino logging to backend #278
Conversation
2690b61
to
6b5b3c2
Compare
This is what happens when I use the github gui as opposed to the command line... |
You can fix it like this:
|
@miggs125 you're my first victim due to #295 landing! Can you please rebase on master, and get rid of the changes to package-lock.json. If it were me, I might do something like this:
If it goes wrong, I'll help fix it. |
@humphd Thanks for the help! |
How painful was that? Also, I notice your earlier PR set had a version bump on |
@humphd I actually ran into the error before I could read your message but I figured it out. Wasn't super painful but it took a couple of tries |
Flagging @hansal7014 in on this review, since he's worked on the logging code in the past. |
|
||
const log = parentLogger.child({ module: 'count-blog-domain' }); | ||
const log = logger.child({ module: 'count-blog-domain' }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing we'll have to do in another PR is get better at naming our "modules" for the logger. Each class doesn't need its own module name. Rather, we should lump them together into logical components in the app.
prettyPrint: { translateTime: 'SYS: yyyy-mm-dd HH:MM:ss.l ' }, | ||
prettyPrint: { | ||
translateTime: 'SYS: yyyy-mm-dd HH:MM:ss.l ', | ||
colorize: !(os.type() === 'Windows_NT'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch on Windows and colour issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Changes look good to merge. Nice work @miggs125. |
Closes #274