Change splash screen background color #2825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
humphd
reviewed
Feb 4, 2022
.eslintrc.js
Outdated
| rules: { 'no-use-before-define': 'off' }, | ||
| rules: { | ||
| 'no-use-before-define': 'off', | ||
| 'react/jsx-filename-extension': [1, { allow: 'as-needed' }], |
There was a problem hiding this comment.
Why are we making this change? Why not always use .jsx for components?
There was a problem hiding this comment.
@humphd I just check it out and you are right there is no need to do that .jsx work fine
Kevan-Y
approved these changes
Feb 4, 2022
humphd
approved these changes
Feb 4, 2022
aserputov
approved these changes
Feb 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue This PR Addresses
Added for issue #2731
Type of Change
Description
Changing the back ground color of the splash screen and doing a quick check to see if it work on all the phone OS
Steps to test the PR
Checklist
Android.Emulator.-.Pixel_4_API_32_5554.2022-02-03.23-03-49.mp4