New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize the GitHubInfoProvider #2947
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move the GitHubInfo logic from GenericInfoProvider.tsx
to its own component GitHubInfo.tsx
?
Sure! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just learnt about context here in your PR, I think it looks ok. You're going to add youtubeInfo
in following PRs right?
Yeah, I will try to squash and rebase now! |
@dbelokon, let's rebase again and clear this PR! |
Issue This PR Addresses
Fixes #2946
Type of Change
Description
This PR refactors the GitHubInfo Provider so that we can fit other types of data easier.
Steps to test the PR
git fetch dbelokon
, you need a remote reference to my repo first!)git checkout issue-2946
)env.staging
because only the front-end is necessary (pnpm dev
)Checklist