Remove custom healthcheck of status service

[Kevan-Y]

Issue This PR Addresses

Fixes #3263

Type of Change

• Bugfix: Change which fixes an issue
• New Feature: Change which adds functionality
• Documentation Update: Change which improves documentation
• UI: Change which improves UI

Description

Removed custom healthcheck in status service. getPackage() is not needed here. Because we don't have proper try/catch getPackage + with recent change in Dockerfile with Healthcheck. It made the whole services crash.

I looked at the code, it seems without this (code removed in custom healthcheck) getting the version doesn't have any issue in staging and production.

For the development side to display the version, we have to run pnpm start which start our backend that a API route that return the version and commit for our backend.
https://github.com/Seneca-CDOT/telescope/blob/master/src/backend/web/routes/health.js

Final solution

Removing the custom healthcheck in status services, and in our front-end we do the fetch directly there.

Steps to test the PR

Development

• pnpm services:start
• Go to localhost:8000

Staging/Production not able to test, but technically it should work.

Checklist

• Quality: This PR builds and passes our npm test and works locally
• Tests: This PR includes thorough tests or an explanation of why it does not
• Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
• Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

[gitpod-io]

[manekenpix]

I'm not sure if this is a good idea. If I remember correctly, this change was made because the backend service is going to disappear once all the microservices are implemented, and we won't be able to get the information we need to display version and commit, that's why status was selected as the provider of this information. There's a conversation about injecting this information at build time in the CI, but that would make some parts of the hero banner almost undebuggable, so I don't know what the right solution is here.

[humphd]

cc @DukeManh, this shouldn't be happening, right? Has that .npmrc change not landed yet?

[DukeManh]

Looks like Kevan just picked up the change

[DukeManh]

@Kevan-Y, there's a recent change on master to download published packages from the npm registry versus using local packages.
To pick it up, remove pnpm-lock and let pnpm generates the file again.

[HyperTHD]

Might be the same issue that David mentioned above? I'm not familiar with the latest stuff added since Satellite was recently incorporated

[HyperTHD]

Seconding @manekenpix's suggestion that we keep the info for now. I didn't properly incorporate the healthcheck when I wrote it awhile back so my fault for this

[Kevan-Y]

@humphd , @manekenpix, @HyperTHD How about removing the custom healthcheck in status services, and in our front-end we do the fetch directly there.

telescope/src/web/src/components/Banner.tsx

Line 145 in d8e1f7d

const res = await fetch(`${telescopeUrl}/health`);

We can fetch this https://raw.githubusercontent.com/Seneca-CDOT/telescope/master/package.json, which get the data of our package.json.
For GIT_COMMIT I think we can do the same thing as before by passing in env

[DukeManh]

@Kevan-Y, there's a recent change on master to download published packages from the npm registry versus using local packages.
To pick it up, remove pnpm-lock and let pnpm generates the file again.

[TueeNguyen]

Learned more nginx stuff from this.

[JerryHue]

So, if I understand everything from this PR, in the case of deploying for production, we would need to generate a config that has the specific SHA for that release.

Very good work!

[manekenpix]

LGTM 👍