Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docusaurus broken links #3376

Merged
merged 1 commit into from Apr 2, 2022
Merged

Fix docusaurus broken links #3376

merged 1 commit into from Apr 2, 2022

Conversation

menghif
Copy link
Contributor

@menghif menghif commented Apr 1, 2022 •
edited

Issue This PR Addresses

Fixes #3048

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Steps to test the PR

  • cd ./src/web/docusaurus
  • docker build -t docs:prod .

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Apr 1, 2022

TueeNguyen
TueeNguyen approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@TueeNguyen TueeNguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, these files are not in src/web/docusaurus => use absolute path

@menghif menghif self-assigned this Apr 1, 2022
@TueeNguyen TueeNguyen added this to the 3.0-alpha Release milestone Apr 1, 2022
@TueeNguyen TueeNguyen added the area: docusaurus Anything related to Docusaurus label Apr 1, 2022
@menghif menghif merged commit a47722d into Seneca-CDOT:master Apr 2, 2022
@menghif menghif deleted the issue-3048 branch April 2, 2022 02:22
@manekenpix manekenpix mentioned this pull request Apr 2, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TueeNguyen TueeNguyen TueeNguyen approved these changes

@nguyenhung15913 nguyenhung15913 nguyenhung15913 approved these changes

@tcvan0707 tcvan0707 tcvan0707 approved these changes

Assignees

@menghif menghif

Labels
area: docusaurus Anything related to Docusaurus
Projects
None yet
Milestone
3.0-alpha Release
Development

Successfully merging this pull request may close these issues.

Docusaurus broken links.
4 participants
@menghif @TueeNguyen @nguyenhung15913 @tcvan0707