Remove src attribute on <img> to avoid failing with fetch not existing in JSDOM #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manekenpix
approved these changes
Nov 25, 2019
manekenpix
requested review from
c3ho,
Cadesh,
cindyledev,
evlnyng,
KarlaChen and
miggs125
UltimaBGD
approved these changes
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #343, removing the
srcattribute on the test case's<img>element, thus papering over the issue with DOMPurify/JSDOM andfetch()not being present.Probably the right fix is to move to using Puppeteer and a full DOM in the future.