Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image flickering on star field #3512

Merged
merged 1 commit into from Apr 19, 2022
Merged

Conversation

dbelokon
Copy link
Contributor

Issue This PR Addresses

Fixes #3193.

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

This PR fixes the image flickering on the star field.

Steps to test the PR

You can run in the deployment, but if you want to run on your PC:

  1. Get my changes.
  2. If you don't have them, I suggest you copy the staging configuration (cp config/env.staging .env)
  3. Run pnpm dev
  4. Go to localhost:8000
  5. Go to the About page

No more flickering!

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Apr 19, 2022

Copy link
Contributor

@sirinoks sirinoks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No flickering, works for me

Copy link
Contributor

@JerryHue JerryHue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't believe it was a two-line fix... And here I was thinking that we had to rewrite the whole math simulation. Neato solution!

@JerryHue JerryHue merged commit bd66b51 into Seneca-CDOT:master Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix image profile flickering on star field
5 participants