Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #31: Add editor config file to repo #36

Merged
merged 1 commit into from Nov 5, 2019
Merged

Fix #31: Add editor config file to repo #36

merged 1 commit into from Nov 5, 2019

Conversation

ragnarokatz
Copy link
Contributor

No description provided.

@ragnarokatz
Copy link
Contributor Author

reference issue #31

@ragnarokatz ragnarokatz mentioned this pull request Nov 5, 2019
Closed
humphd
humphd approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Get some others to approve it too, please.

Also, let's file another issue to add docs on how to use this (e.g., what you have to do in order for your editor to honour these settings).

@ODAVING
Copy link
Contributor

ODAVING commented Nov 5, 2019

Looks good to me! @ragnarokatz

@ODAVING ODAVING merged commit 847af1e into Seneca-CDOT:master Nov 5, 2019
@humphd
Copy link
Contributor

humphd commented Nov 5, 2019 •
edited

@ragnarokatz please file another issue to deal with the documentation side of this, and link the issue number in here. Someone else can fix it, but you should file it, so we make sure that it happens.

#39 already has the bug for documenting this, I missed that, sorry.

@Reza-Rajabi Reza-Rajabi added this to Done in Main Nov 6, 2019
@cindyledev cindyledev mentioned this pull request Nov 7, 2019
Closed
@ragnarokatz ragnarokatz changed the title Add editor config file to repo Fix #31: Add editor config file to repo Nov 7, 2019
menghif pushed a commit to menghif/telescope that referenced this pull request Mar 8, 2022
@cindyledev
Merge pull request Seneca-CDOT#36 from Seneca-CDOT/renovate/husky-5.x
b0f3dce 
chore(deps): update dependency husky to v5.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humphd humphd humphd approved these changes

@ODAVING ODAVING ODAVING approved these changes

@birtony birtony Awaiting requested review from birtony

@Immutablevoid Immutablevoid Awaiting requested review from Immutablevoid

@jerryshueh jerryshueh Awaiting requested review from jerryshueh

@kartik-budhiraja kartik-budhiraja Awaiting requested review from kartik-budhiraja

@miggs125 miggs125 Awaiting requested review from miggs125

@Reza-Rajabi Reza-Rajabi Awaiting requested review from Reza-Rajabi

@RyanWils RyanWils Awaiting requested review from RyanWils

@UltimaBGD UltimaBGD Awaiting requested review from UltimaBGD

@vitokhangnguyen vitokhangnguyen Awaiting requested review from vitokhangnguyen

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Main
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ragnarokatz @ODAVING @humphd @Reza-Rajabi