Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #31: Add editor config file to repo #36

Conversation

@ragnarokatz
Copy link
Collaborator

ragnarokatz commented Nov 5, 2019

No description provided.

@ragnarokatz

This comment has been minimized.

Copy link
Collaborator Author

ragnarokatz commented Nov 5, 2019

reference issue #31

@humphd
humphd approved these changes Nov 5, 2019
Copy link
Contributor

humphd left a comment

Looks good to me. Get some others to approve it too, please.

Also, let's file another issue to add docs on how to use this (e.g., what you have to do in order for your editor to honour these settings).

@ODAVING

This comment has been minimized.

Copy link
Contributor

ODAVING commented Nov 5, 2019

Looks good to me! @ragnarokatz

@ODAVING
ODAVING approved these changes Nov 5, 2019
@ODAVING ODAVING merged commit 847af1e into Seneca-CDOT:master Nov 5, 2019
@humphd

This comment has been minimized.

Copy link
Contributor

humphd commented Nov 5, 2019

@ragnarokatz please file another issue to deal with the documentation side of this, and link the issue number in here. Someone else can fix it, but you should file it, so we make sure that it happens.

#39 already has the bug for documenting this, I missed that, sorry.

@Reza-Rajabi Reza-Rajabi added this to Done in Main Nov 6, 2019
@ragnarokatz ragnarokatz changed the title Add editor config file to repo Fix #31: Add editor config file to repo Nov 7, 2019
@Reza-Rajabi Reza-Rajabi added the on-board label Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.