Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #197, fixes #199: revamp inactive-blog-filter and tests #395

Merged
merged 6 commits into from Dec 2, 2019
Merged

Fixes #197, fixes #199: revamp inactive-blog-filter and tests #395

merged 6 commits into from Dec 2, 2019

Conversation

Silvyre
Copy link
Contributor

@Silvyre Silvyre commented Dec 1, 2019 •
edited

Fixes #197: builds upon #211 and #380 to boost testing coverage for inactive-blog-filter.js into the green (representing a significant step towards the resolution of #268).

Fixes #199: both the check() and update() functions of inactive-blog-filter.js now use fs.promises. Thank you, @MeisterRed, for agreeing to collaborate!

@Silvyre Silvyre added the type: test Creation and development of test label Dec 1, 2019
@Silvyre Silvyre self-assigned this Dec 1, 2019
@Immutablevoid
Copy link
Contributor

Immutablevoid commented Dec 1, 2019 •
edited

Do you think it's possible to split updating inactive-blog-filter to use promises and improving test coverage for inactive-blog-filter to different PRs? It would make reviewing this a lot easier.

@Silvyre
Copy link
Contributor Author

Silvyre commented Dec 1, 2019

That might be a bit tricky, Paul, as the updated inactive-blog-filter.js is incompatible with the current inactive-blog-filter.test.js, and vice versa.

@Immutablevoid
Copy link
Contributor

That might be a bit tricky, Paul, as the updated inactive-blog-filter.js is incompatible with the current inactive-blog-filter.test.js, and vice versa.

Alright, that makes sense. It might take a little bit to review, since it's somewhat of a big change.

@Silvyre
Copy link
Contributor Author

Silvyre commented Dec 1, 2019

Sure thing; thanks for all the help!

Immutablevoid
Immutablevoid reviewed Dec 1, 2019
View reviewed changes
Copy link
Contributor

@Immutablevoid Immutablevoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good, I couldn't find any problems running it. Good work 👍!

src/backend/utils/inactive-blog-filter.js Show resolved Hide resolved
@Immutablevoid Immutablevoid self-requested a review December 1, 2019 22:28
MeisterRed
MeisterRed approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@MeisterRed MeisterRed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty good. I've ran the tests on my computer and haven't encountered any issues on my end.

@Silvyre Silvyre merged commit f2af1a2 into Seneca-CDOT:master Dec 2, 2019
@Silvyre Silvyre deleted the issue-197 branch December 2, 2019 02:58
@Silvyre Silvyre mentioned this pull request Dec 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Immutablevoid Immutablevoid Immutablevoid approved these changes

@MeisterRed MeisterRed MeisterRed approved these changes

@jerryshueh jerryshueh Awaiting requested review from jerryshueh

@cindyledev cindyledev Awaiting requested review from cindyledev

Assignees

@Silvyre Silvyre

Labels
type: test Creation and development of test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make inactive blog filter update asynchronous add test case for issue #22
3 participants
@Silvyre @Immutablevoid @MeisterRed