Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #575: Change ESlint configuration to accept React #578

Merged
merged 1 commit into from Jan 22, 2020
Merged

Fix #575: Change ESlint configuration to accept React #578

merged 1 commit into from Jan 22, 2020

Conversation

agarcia-caicedo
Copy link
Contributor

@agarcia-caicedo agarcia-caicedo commented Jan 22, 2020 •
edited

Issue This PR Addresses

Fixes #575

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

In order for Gatsby to pass the ESlint tests, eslint-react-plugin needed to be installed. Other rules to accept .jsx syntax in .js files were added.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@humphd
Copy link
Contributor

humphd commented Jan 22, 2020

@agarcia-caicedo can you add a line in the description above under the title "Issue This PR Addresses" that says "Fixes #575" so that it auto closes?

Grommers00
Grommers00 approved these changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@Grommers00 Grommers00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and it moves it forward. Need this to get the front end moving.

@agarcia-caicedo agarcia-caicedo added this to In progress/Review in Main via automation Jan 22, 2020
cindyledev
cindyledev approved these changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@cindyledev cindyledev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this

@cindyledev cindyledev merged commit 1c4b7b0 into Seneca-CDOT:master Jan 22, 2020
Main automation moved this from In progress/Review to Done Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cindyledev cindyledev cindyledev approved these changes

@Grommers00 Grommers00 Grommers00 approved these changes

@miggs125 miggs125 Awaiting requested review from miggs125

@Silvyre Silvyre Awaiting requested review from Silvyre

@c3ho c3ho Awaiting requested review from c3ho

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Main
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for React in our ESlint configuration
4 participants
@agarcia-caicedo @humphd @cindyledev @Grommers00