Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #581: cleaning up package.json in src/frontend from unnecessary info #655

Closed
wants to merge 1 commit into from

Conversation

lozinska
Copy link
Contributor

@lozinska lozinska commented Feb 5, 2020

Issue This PR Addresses

Fixes #581

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Remove redundant information from src/frontend/package.json.
Also I have changed template GatsbyJS name "name": "gatsby-starter-default", to "name": "gatsby-for-telescope" in src/frontend/package.json and src/frontend/gatsby-config.json.
description: is updated as well src/frontend/package.json

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@vercel
Copy link

vercel bot commented Feb 5, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/humphd/telescope/f7ko4t7ut
✅ Preview: https://telescope-git-fork-lozinska-issue-581.humphd.now.sh

Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not the same thing you're doing in the other PR I just reviewed?

@lozinska
Copy link
Contributor Author

lozinska commented Feb 5, 2020

@humphd this PR should be close, I realize that they were same when I was going through issue-580, but my PR by then was already up

@lozinska lozinska closed this Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant information from frontend package.json
2 participants