fix #707 adding post route for /feeds

[Grommers00]

Issue This PR Addresses

• Bugfix: Change which fixes an issue
• New Feature: Change which adds functionality
• Documentation Update: Change which improves documentation
• UI: Change which improves UI

Description

This will allow us to connect our front end and back end to post the data to add the feeds to the master list.

Checklist

• Quality: This PR builds and passes our npm test and works locally
• Tests: This PR includes thorough tests or an explanation of why it does not
• Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
• Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

[humphd]

This also needs some tests.

[humphd]

Code looks good. What are we doing about tests? I think we should get some in so we know this works.

[Silvyre]

I like the handling for various status codes!

[manekenpix]

I think you can include your tests in the describe that we already have so you won't have to repeat code (DRY vs WET)

[Grommers00]

I think you can include your tests in the describe that we already have so you won't have to repeat code (DRY vs WET)

Not sure about this because a Post route is different than a GET route. Unless you were referring to something different?

[manekenpix]

Not sure about this because a Post route is different than a GET route. Unless you were referring to something different?

You're right. If you end up not using beforeAll maybe it's better to have your tests in a different set.

[humphd]

Some really good ideas in here. I'll just add/answer a few more:

• consider each test as an individual "unit", and don't rely on anything external to that test if possible. For example, if you need some data to use, create it in that test. I usually do this by having functions that return data, and call them over and over again in different tests vs. creating variables. Variables are what make tests fail.
• Tests can and will run in any order. As such, don't have one test depend on state from another (e.g., don't add something in one test, and try to read it in the next test).
• Tests might not all get run. A dev might run a single test, so don't rely on anything in other tests.
• If you require the world to be in a certain state for your test, do that in the test itself. If all your tests need that, do beforeAll() or beforeEach(), but prefer doing things in the test if possible so you know they happened in the order you need them to, and nothing else changed their state.

In summary: don't share data between tests, don't rely on one test in another, don't rely on test order.

updated commit.

[humphd]

Really good. A few small things, and this is R+ from me.

[Silvyre]

Congrats on your first Jest test!

[humphd]

Let's add one more thing to your tests, so we know that the feed gets added. I think that's it, the rest looks great.

updated

[manekenpix]

👍