Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #832: Documentation for Full-Text Indexing(ElasticSearch) #834

Merged
merged 4 commits into from Mar 14, 2020
Merged

Closes #832: Documentation for Full-Text Indexing(ElasticSearch) #834

merged 4 commits into from Mar 14, 2020

Conversation

manekenpix
Copy link
Member

Issue This PR Addresses

Closes #832

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Documentation for environment setup and usage.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@manekenpix manekenpix added type: documentation (docs) Improvements or additions to documentation area: elasticsearch Elasticsearch Related issues and pull requests labels Mar 12, 2020
@manekenpix manekenpix added this to In progress in 0.8 Release: "Goodbye Random Pants" via automation Mar 12, 2020
@manekenpix manekenpix changed the title Add elasticsearch documentation Closes #832: Documentation for Full-Text Indexing(ElasticSearch) Mar 12, 2020
c3ho
c3ho requested changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@c3ho c3ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear and concise, just a few quick comments. Otherwise I'm happy with it.

docs/elasticsearch.md Show resolved Hide resolved
docs/elasticsearch.md Show resolved Hide resolved
docs/environment-setup.md Show resolved Hide resolved
@manekenpix manekenpix requested a review from c3ho March 12, 2020 14:17
c3ho
c3ho previously approved these changes Mar 12, 2020
View reviewed changes
@c3ho
Copy link
Contributor

c3ho commented Mar 12, 2020

Ty for changes!

cindyledev
cindyledev reviewed Mar 13, 2020
View reviewed changes
docs/elasticsearch.md Outdated
- If you want to see the state of the cluster (`cURL`):

```sh
curl -X GET 'localhost:9200/\_cluster/health?pretty'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo here, should be /_cluster/ not /\_cluster/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw you approved the PR. Should I change this or it's ok?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

cindyledev
cindyledev previously approved these changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@cindyledev cindyledev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this on Linux using both docker and native installation. Everything works according to the instructions provided here

@manekenpix manekenpix dismissed stale reviews from cindyledev and c3ho via 8a2d1f2 March 14, 2020 04:47
@manekenpix manekenpix merged commit a478202 into Seneca-CDOT:master Mar 14, 2020
0.8 Release: "Goodbye Random Pants" automation moved this from In progress to Done Mar 14, 2020
@manekenpix manekenpix deleted the elasticdocs branch September 8, 2020 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c3ho c3ho c3ho approved these changes

@cindyledev cindyledev cindyledev approved these changes

@humphd humphd Awaiting requested review from humphd

Assignees
No one assigned
Labels
area: elasticsearch Elasticsearch Related issues and pull requests type: documentation (docs) Improvements or additions to documentation
Projects
No open projects
0.8 Release: "Goodbye Random Pants"
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation for Full-Text Indexing(ElasticSearch)
3 participants
@manekenpix @c3ho @cindyledev