Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary .css files and logo component #857

Merged
merged 2 commits into from Mar 22, 2020
Merged

Remove unnecessary .css files and logo component #857

merged 2 commits into from Mar 22, 2020

Conversation

cindyledev
Copy link
Contributor

@cindyledev cindyledev commented Mar 22, 2020 •
edited

Issue This PR Addresses

Fixes #856
Related #770

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Removes

  • AuthorResult.css (file is blank)
  • Header.css (file is also blank)
  • Layout.css (styles are not being applied so this is useless)
  • Logo component (COMPONENT ONLY, not the logo.svg file)

We are currently trying to change our code so it follows MUI, this means the styling and JavaScript are married and are not in separate files. Any styling is done using theme.js or in the component themselves.

Logo component isn't being used at all so it should be removed.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@cindyledev cindyledev self-assigned this Mar 22, 2020
@cindyledev cindyledev added 5 min fix Fixable in 5 minutes or less area: front-end labels Mar 22, 2020
@cindyledev cindyledev added this to In progress in UI and Frontend via automation Mar 22, 2020
@cindyledev cindyledev added this to In progress in 0.8 Release: "Goodbye Random Pants" via automation Mar 22, 2020
@cindyledev cindyledev changed the title delete unnecessary .css files Remove unnecessary .css files and logo component Mar 22, 2020
agarcia-caicedo
agarcia-caicedo approved these changes Mar 22, 2020
View reviewed changes
Copy link
Contributor

@agarcia-caicedo agarcia-caicedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to declutter from these unused files

UI and Frontend automation moved this from In progress to Reviewer approved Mar 22, 2020
manekenpix
manekenpix approved these changes Mar 22, 2020
View reviewed changes
Copy link
Member

@manekenpix manekenpix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cindyledev cindyledev merged commit 78610d4 into Seneca-CDOT:master Mar 22, 2020
UI and Frontend automation moved this from Reviewer approved to Done Mar 22, 2020
0.8 Release: "Goodbye Random Pants" automation moved this from In progress to Done Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manekenpix manekenpix manekenpix approved these changes

@agarcia-caicedo agarcia-caicedo agarcia-caicedo approved these changes

Assignees

@cindyledev cindyledev

Labels
5 min fix Fixable in 5 minutes or less area: front-end
Projects
No open projects
0.8 Release: "Goodbye Random Pants"
  
Done
UI and Frontend
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unnecessary .css files
3 participants
@cindyledev @manekenpix @agarcia-caicedo