Fix #880: add pushRepo to github release step in release-it, update version #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t, update version.
humphd
added this to In progress
in 0.9 Release: "we don't speak about 0.8"
via automation
c3ho
approved these changes
Mar 27, 2020
0.9 Release: "we don't speak about 0.8"
automation
moved this from In progress
to Reviewer approved
Mar 27, 2020
0.9 Release: "we don't speak about 0.8"
automation
moved this from Reviewer approved
to Done
Mar 27, 2020
|
@Silvyre when you have time today or over the weekend, try updating your master, and re-running a release for 0.8.2 and see if it behaves. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue This PR Addresses
Fixes #880
Type of Change
Description
We filed an upstream bug after @Silvyre tried to run our release, and it put the assets in the wrong repo. The bug was fixed, so I've updated our version of release it and added a
pushRepofor our GitHub Release section in the config.After we land this, I'll get @Silvyre to do a 0.8.3 release to test it.