Fix #5: Initial commit of html, css, and images #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
reference issue #5 |
|
how it currently looks: here |
|
Now that we are using a static web page rather than a dynamic component-based, don't we need to use some template like handlebars to load the data on the compiled html instead of repeating html tags for each feed? |
|
I’m perfectly dine with merging this and continuously working on it! And developing it further! @humphd would that be feasible? |
|
This is good but it's currently over 20 commits behind master, please rebase this. |
Closed
|
I can get this updated. I'll send out a review request once it's done. |
ragnarokatz
force-pushed
the
issue-4-copy-basic-template-css-files-over
branch
from
748f08e
to
43d95fa
Compare
ragnarokatz
changed the title
|
@ragnarokatz can you please squash both commits together? |
ragnarokatz
requested review from
birtony,
Grommers00,
jatinAroraGit,
jerryshueh,
lozinska,
lucacataldo,
manekenpix,
a user,
RyanMarzec and
UltimaBGD
on zenit Initial commit of html, css, and images copied over from current planet on zenit Replace old doctype html with simpler one
lucacataldo
suggested changes
Nov 7, 2019
ragnarokatz
force-pushed
the
issue-4-copy-basic-template-css-files-over
branch
from
43d95fa
to
856f0ae
Compare
|
@ODAVING @lucacataldo done. please take another look when you have time, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial commit of html, css, and images copied over from current planet site hosted on zenit.