Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpotOn V2 Release #32

Merged
merged 1 commit into from
Aug 27, 2023
Merged

SpotOn V2 Release #32

merged 1 commit into from
Aug 27, 2023

Conversation

SenpaiHunters
Copy link
Owner

@SenpaiHunters SenpaiHunters commented Aug 27, 2023

SpotOn V2 Release, please read the full patch notes in Releases!

Signed-off-by: Kami on YT <kamibusinessinquirers@gmail.com>
Comment on lines +136 to +143
try {
usingVolumeSlider(command);
console.log(`[SpotOn Hotkeys] Changed volume slider for '${command}'.`);
} catch (error) {
console.error(
`[SpotOn Hotkeys] Error while changing volume slider for '${command}': ${error}`
);
}

Check warning

Code scanning / nodejsscan

Error messages with stack traces may expose sensitive information about the application. Warning

Error messages with stack traces may expose sensitive information about the application.
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used as testing to send which hotkey is being sent, this is fine

if (document.getElementById("background") != null) {
document.getElementById("background").remove();
}
sheet.innerHTML = ":root{ --backimg:url(" + coverartimage.src + ");}";

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML Medium

DOM text
is reinterpreted as HTML without escaping meta-characters.
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine

if (document.getElementById("background") != null) {
document.getElementById("background").remove();
}
sheet.innerHTML = ":root{ --backimg:url(" + coverartimage.src + ");}";

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML Medium

DOM text
is reinterpreted as HTML without escaping meta-characters.
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As i said above

@SenpaiHunters SenpaiHunters merged commit 0a80dce into Main Aug 27, 2023
5 checks passed
@SenpaiHunters SenpaiHunters deleted the SpotOn-V2-Release branch August 27, 2023 10:42
@SenpaiHunters
Copy link
Owner Author

SpotOn V2, my biggest release. There is a lot, so much that's its not all in the Release notes! Please, if you have issues come and chat on our discord!
https://discord.gg/9hqVqYDpj3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant