-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SpotOn V2 Release #32
Conversation
Signed-off-by: Kami on YT <kamibusinessinquirers@gmail.com>
SpotOn/background.js
Dismissed
try { | ||
usingVolumeSlider(command); | ||
console.log(`[SpotOn Hotkeys] Changed volume slider for '${command}'.`); | ||
} catch (error) { | ||
console.error( | ||
`[SpotOn Hotkeys] Error while changing volume slider for '${command}': ${error}` | ||
); | ||
} |
Check warning
Code scanning / nodejsscan
Error messages with stack traces may expose sensitive information about the application. Warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used as testing to send which hotkey is being sent, this is fine
SpotOn/options/addLyrics.js
Dismissed
if (document.getElementById("background") != null) { | ||
document.getElementById("background").remove(); | ||
} | ||
sheet.innerHTML = ":root{ --backimg:url(" + coverartimage.src + ");}"; |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
DOM text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine
SpotOn/options/addLyrics.js
Dismissed
if (document.getElementById("background") != null) { | ||
document.getElementById("background").remove(); | ||
} | ||
sheet.innerHTML = ":root{ --backimg:url(" + coverartimage.src + ");}"; |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
DOM text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As i said above
SpotOn V2, my biggest release. There is a lot, so much that's its not all in the Release notes! Please, if you have issues come and chat on our discord! |
SpotOn V2 Release, please read the full patch notes in Releases!