Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Draft Queue #457

Merged
merged 28 commits into from
May 9, 2023
Merged

[Feature] Draft Queue #457

merged 28 commits into from
May 9, 2023

Conversation

Senryoku
Copy link
Owner

@Senryoku Senryoku commented May 4, 2023

Very WIP PoC of a Draft Queue page.
Join a queue for training drafts of the 2/3 most recent sets with other random human players.
100% Hackish for now.

Main change is allowing a session to function without an owner and a queue system managing these sessions.

Needed improvements:

  • Ready check before actually launching the draft (Arena style?).
  • Add a timeout to the force pick. Added a hackish workaround to avoid reworking the timer system for now.
  • Allow draft to continue with disconnected players.
  • Auto replace disconnected players after some time.
  • Improve UI after the draft end (Clear links to homepage/back to queue)

About the name: I'd like to use "Quick Draft", but since it's Arena's name for its bot drafts, I should probably use something else (especially since I'd like to extend that idea to allow launching bot drafts from an simpler interface).

@NerdyNathan
Copy link
Contributor

Name suggestions:

  • Draft Queue
  • Queue [to] Draft
  • Draft with Strangers
  • Join Draft

@Senryoku Senryoku changed the title [Feature] Quick Draft [Feature] Draft Queue May 8, 2023
@Senryoku Senryoku marked this pull request as ready for review May 9, 2023 14:14
@Senryoku Senryoku merged commit 0955c5f into master May 9, 2023
5 checks passed
@Senryoku Senryoku deleted the feat/MockDraft branch July 9, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants